lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Dec 2009 12:56:06 +0000 From: "Hennerich, Michael" <Michael.Hennerich@...log.com> To: "Marcel Holtmann" <marcel@...tmann.org> CC: "Mike Frysinger" <vapier@...too.org>, <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, <uclinux-dist-devel@...ckfin.uclinux.org> Subject: RE: [PATCH] wireless: adf702x: new driver for ADF7020/21 parts Hi Marcel, >From: Marcel Holtmann [mailto:marcel@...tmann.org] > >Hi Michael, > >> >> This is a driver for Analog Devices series of ADF702x Narrow-Band >> >> Short-Range Radio Transceiver chipsets, including the ADF7021 and >> >> the ADF7025. This Ethernet like driver implements a custom >> >> software PHY. >> > >> >while it might be a little bit confusing, but the wireless directory >> >normally only contains Wireless LAN (aka 802.11 and alike) drivers. >> > >> >If this implements some sort of Ethernet driver, then it might be >better >> >to just put it under drivers/net/ to not intermix and confuse it with >> >actually 802.11 drivers. >> >> No problem we can relocate >> >> > >> >> drivers/net/wireless/Kconfig | 11 + >> >> drivers/net/wireless/Makefile | 2 + >> >> drivers/net/wireless/adf702x.c | 788 >> >++++++++++++++++++++++++++++++++++++++++ >> >> include/linux/spi/adf702x.h | 33 ++ >> >> 4 files changed, 834 insertions(+), 0 deletions(-) >> >> create mode 100644 drivers/net/wireless/adf702x.c >> >> create mode 100644 include/linux/spi/adf702x.h >> > >> >And why is the header file under SPI includes. It could be as easily >in >> >the same directory as the driver *.c file itself. No reason to spread >it >> >over the whole tree if nothing else includes it. >> >> It under include/linux/spi/ because it includes platform data which is >used by board support files. > >that is no argument to move it there. It is a driver specific header and >so keep it in the same location as the driver itself. > >Regards > >Marcel > Most of the other include files under include/spi, include/i2c, include/mfd, include/input are there for exactly the same reason. I consider it common practice to locate struct platform data in the includes and not in the drivers. -Michael
Powered by blists - more mailing lists