netdev - Re: [Uclinux-dist-devel] [PATCH] wireless: adf702x: new driver for ADF7020/21 parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0912220509w641a4e2cv615bc6d690cabab0@mail.gmail.com>
Date:	Tue, 22 Dec 2009 08:09:43 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] wireless: adf702x: new driver for 
	ADF7020/21 parts

On Tue, Dec 22, 2009 at 07:46, Marcel Holtmann wrote:
>> >>  drivers/net/wireless/Kconfig   |   11 +
>> >>  drivers/net/wireless/Makefile  |    2 +
>> >>  drivers/net/wireless/adf702x.c |  788
>> >>  include/linux/spi/adf702x.h    |   33 ++
>> >>  4 files changed, 834 insertions(+), 0 deletions(-)
>> >>  create mode 100644 drivers/net/wireless/adf702x.c
>> >>  create mode 100644 include/linux/spi/adf702x.h
>> >
>> >And why is the header file under SPI includes. It could be as easily in
>> >the same directory as the driver *.c file itself. No reason to spread it
>> >over the whole tree if nothing else includes it.
>>
>> It under include/linux/spi/ because it includes platform data which is used by board support files.
>
> that is no argument to move it there. It is a driver specific header and
> so keep it in the same location as the driver itself.

that is incorrect.  for devices that need platform resources, the
structure is in a header in the include/ tree.  it cannot be in
drivers/net/ where boards are unable to include it.

whether it goes in linux/spi/ or linux/net/ or somewhere else we dont
really care.  linux/spi/ seems to be the best match so far.
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html