netdev - gianfar select_queue bogosity (was Re: ixgbe warning)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091223.211157.68124463.davem@davemloft.net>
Date:	Wed, 23 Dec 2009 21:11:57 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	yinghai@...nel.org, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, netdev-owner@...r.kernel.org,
	avorontsov@...mvista.com, Sandeep.Kumar@...escale.com,
	galak@...nel.crashing.org
Subject: gianfar select_queue bogosity (was Re: ixgbe warning)

From: Krishna Kumar2 <krkumar2@...ibm.com>
Date: Wed, 23 Dec 2009 12:57:26 +0530

> Also, I was looking at other providers of select_queue and found:
> 
> u16 gfar_select_queue(struct net_device *dev, struct sk_buff *skb)
> {
>         return skb_get_queue_mapping(skb);
> }
> 
> How can this be correct (driver supports upto 8 txq's). Unless txq=0 for
> xmits of all locally
> generated packets is fine.

This must be fixed.  As you note the queue mapping is only set
for forwarding/bridging cases.

There is zero reason for this driver to have it's own select_queue
function, so the fix seems to simply remove this thing altogether.

Some gianfar developer please prepare such a patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html