netdev - RE: gianfar select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9F4C7D19E8361D4C94921B95BE08B81BA0904F@zin33exm22.fsl.freescale.net>
Date:	Thu, 24 Dec 2009 12:06:09 +0530
From:	"Kumar Gopalpet-B05799" <B05799@...escale.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<krkumar2@...ibm.com>, <yinghai@...nel.org>,
	<e1000-devel@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
	<netdev-owner@...r.kernel.org>, <avorontsov@...mvista.com>,
	<galak@...nel.crashing.org>
Subject: RE: gianfar select_queue bogosity

 

>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net] 
>Sent: Thursday, December 24, 2009 12:00 PM
>To: Kumar Gopalpet-B05799
>Cc: krkumar2@...ibm.com; yinghai@...nel.org; 
>e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org; 
>netdev-owner@...r.kernel.org; avorontsov@...mvista.com; 
>galak@...nel.crashing.org
>Subject: Re: gianfar select_queue bogosity
>
>From: "Kumar Gopalpet-B05799" <B05799@...escale.com>
>Date: Thu, 24 Dec 2009 11:34:23 +0530
>
>> What if I want to maintaing a 1-1 mapping b/w the Rx/Tx queues.
>> For eg., I want a packet received on queue-1 on eth0 to be forwarded 
>> on to queue-1 on eth1.
>
>That's what the default code does when forwarding/bridging!
>
>And for locally generated packets it uses the flow hash.
>
>What do you think we do by default?  Go read the code :-)
>

OOPS ..I am really sorry. I should have given a little thought before
providing the gfar_select_queue( ) function. Thanks for the pointer.

But then, on the Rx-side, we should also set the "queue_mapping" as
"queue_mapping +1", since skb_get_rx_queue( ) returns "queue_mapping
-1". Is this correct ?


--

Thanks
Sandeep
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html