netdev - Re: [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091225.182102.112589642.davem@davemloft.net>
Date:	Fri, 25 Dec 2009 18:21:02 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org,
	508527@...s.debian.org
Subject: Re: [PATCH] via-velocity: Give RX descriptors to the NIC later on
 open or MTU change

From: Ben Hutchings <ben@...adent.org.uk>
Date: Tue, 15 Dec 2009 02:05:09 +0000

> velocity_open() calls velocity_give_many_rx_descs(), which gives RX
> descriptors to the NIC, before installing an interrupt handler or
> calling velocity_init_registers().  I think this is very unsafe and it
> appears to explain the bug report <http://bugs.debian.org/508527>.
> 
> On MTU change, velocity_give_many_rx_descs() is again called before
> velocity_init_registers().  I'm not sure whether this is unsafe but
> it does look wrong.
> 
> Therefore, move the calls to velocity_give_many_rx_descs() after
> request_irq() and velocity_init_registers().
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
> This is untested; I don't have this hardware.

Although this patch looks fine to me, I don't want to apply
it until someone tests it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html