netdev - Re: [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B3879FD.60102@computer.org>
Date:	Mon, 28 Dec 2009 10:27:25 +0100
From:	Jan Ceuleers <jan.ceuleers@...puter.org>
To:	David Miller <davem@...emloft.net>
CC:	ben@...adent.org.uk, romieu@...zoreil.com, netdev@...r.kernel.org,
	508527@...s.debian.org
Subject: Re: [PATCH] via-velocity: Give RX descriptors to the NIC later on
 open or MTU change

David Miller wrote:
>> velocity_open() calls velocity_give_many_rx_descs(), which gives RX
>> descriptors to the NIC, before installing an interrupt handler or
>> calling velocity_init_registers().  I think this is very unsafe and it
>> appears to explain the bug report <http://bugs.debian.org/508527>.
>>
>> On MTU change, velocity_give_many_rx_descs() is again called before
>> velocity_init_registers().  I'm not sure whether this is unsafe but
>> it does look wrong.
>>
>> Therefore, move the calls to velocity_give_many_rx_descs() after
>> request_irq() and velocity_init_registers().
>>
>> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
>> ---
>> This is untested; I don't have this hardware.
> 
> Although this patch looks fine to me, I don't want to apply
> it until someone tests it.

I have successfully booted a 2.6.32.2 kernel with this patch applied on top on a PXE-booting machine with nfsroot. If you consider that to be a sufficient test then please feel free to add my

Tested-by: Jan Ceuleers <jan.ceuleers@...puter.org>

Otherwise, please let me know which other tests you would like me to carry out.

Note though that I am unable to reproduce the original bug on my system.

Cheers, Jan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html