netdev - Re: [PATCH] drivers/net/stmmac/gmac.c: use %pM to show MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B42F226.6010207@st.com>
Date:	Tue, 05 Jan 2010 09:02:46 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] drivers/net/stmmac/gmac.c: use %pM to show MAC address

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Hartley,

H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.

Thanks for this patch.
As discussed in the mailing list, I'm reworking some patches for the
stmmac driver (fixing compilation errors and trying to make the code
more generic).
I've already modified the gmac.c file now splitted in new two files.
So I'm wondering if it's worth applying this patch into the new code,
directly.

Regards,
Peppe

> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: David S. Miller <davem@...emloft.net>
> ---
> 
> diff --git a/drivers/net/stmmac/gmac.c b/drivers/net/stmmac/gmac.c
> index 52586ee..7700772 100644
> --- a/drivers/net/stmmac/gmac.c
> +++ b/drivers/net/stmmac/gmac.c
> @@ -481,12 +481,8 @@ static void gmac_set_filter(struct net_device *dev)
>  				gmac_set_umac_addr(ioaddr, uc_ptr->da_addr,
>  						i + 1);
>  
> -				DBG(KERN_INFO "\t%d "
> -				"- Unicast addr %02x:%02x:%02x:%02x:%02x:"
> -				"%02x\n", i + 1,
> -				uc_ptr->da_addr[0], uc_ptr->da_addr[1],
> -				uc_ptr->da_addr[2], uc_ptr->da_addr[3],
> -				uc_ptr->da_addr[4], uc_ptr->da_addr[5]);
> +				DBG(KERN_INFO "\t%d - Unicast addr %pM\n",
> +					i + 1, uc_ptr->da_addr);
>  				uc_ptr = uc_ptr->next;
>  		}
>  	} 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAktC8iAACgkQ2Xo3j31MSSJ+DACguvgHAeRm2Qy+N6Lw8svt/nna
Z0sAnRjHHkG+FYtyu0OfjOrRi8eu9SyN
=srnl
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html