netdev - Re: [RFC 0/9] snet: Security for NETwork syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001050820.o058Kuwx087793@www262.sakura.ne.jp>
Date:	Tue, 05 Jan 2010 17:20:55 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	sam@...ack.fr
Cc:	linux-security-module@...r.kernel.org, kaber@...sh.net,
	zbr@...emap.net, nhorman@...driver.com, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, hadi@...erus.ca
Subject: Re: [RFC 0/9] snet: Security for NETwork syscalls

Samir Bellabes wrote:
> I'm currently testing security_sock_rcv_skb() hook - which is inside
> sk_filter() - to get skbuffs when then are arriving, and so trying to
> push the buffer to userspace. In case this is not userfull, userspace
> is able to use the NFQUEUE of netfilter to get skbuff, and deal
> with incoming datas.

Pushing buffer to userspace and wait for userspace's decision will sleep.
sk_filter() which calls security_sock_rcv_skb() hook is called from
(e.g.) tcp_v6_do_rcv() and comment of tcp_v6_do_rcv() says that
"The socket must have it's spinlock held when we get here." 
Also, comment of rxrpc_queue_rcv_skb() says that
"the caller must hold a lock on call->lock".
I think it is not permitted to do sleeping operation inside
security_sock_rcv_skb().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html