netdev - Re: [PATCH] netpoll: allow execution of multiple rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Jan 2010 20:06:40 +0100
From:	Daniel Borkmann <danborkmann@...glemail.com>
To:	David Miller <davem@...emloft.net>
CC:	mpm@...enic.com, danborkmann@...glemail.com,
	linux-kernel@...r.kernel.org, jmoyer@...hat.com,
	netdev@...r.kernel.org, netdev@....sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface

David Miller wrote:
> From: Matt Mackall <mpm@...enic.com>
> Date: Wed, 06 Jan 2010 21:54:05 -0600
> 
>> Please inline patches so they can be reviewed easily in reply.
>>
>>
>> -       struct netpoll *np = npi->rx_np;
>> +       struct netpoll **np = &npi->rx_np;
>>  
>> -       if (!np)
>> +       if (!(*np))
>>
>> This makes everything horrible. Can you avoid the double indirection?
>> Using a list head might be a good answer.
>>
> 
> Agreed on all counts.
> 

Agreed on the double indirection, I'll fix it.

I've already considered the list_head structure, but then I was the opinion
that a double linked list might not be necessary for this, so I did it that
way ... (compare: kernel notifier by Alan Cox). If you insist on that I'll
fix it of course ;)

Best regards,
Daniel

P.s.: Sorry Matt for not CCing. I mainly took those addresses from Jeffs post.


Download attachment "signature.asc" of type "application/pgp-signature" (262 bytes)