netdev - Re: [PATCH] netpoll: allow execution of multiple rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100107.010201.51693251.davem@davemloft.net>
Date:	Thu, 07 Jan 2010 01:02:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mpm@...enic.com
Cc:	danborkmann@...glemail.com, linux-kernel@...r.kernel.org,
	jmoyer@...hat.com, netdev@...r.kernel.org, netdev@....sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per
 interface

From: Matt Mackall <mpm@...enic.com>
Date: Wed, 06 Jan 2010 21:54:05 -0600

> Please inline patches so they can be reviewed easily in reply.
> 
> 
> -       struct netpoll *np = npi->rx_np;
> +       struct netpoll **np = &npi->rx_np;
>  
> -       if (!np)
> +       if (!(*np))
> 
> This makes everything horrible. Can you avoid the double indirection?
> Using a list head might be a good answer.
> 

Agreed on all counts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html