netdev - Re: [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter programming support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100108.003833.178515565.davem@davemloft.net>
Date:	Fri, 08 Jan 2010 00:38:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, deri@...p.org, joseph.gasparakis@...el.com
Subject: Re: [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter
 programming support

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Fri, 8 Jan 2010 00:34:23 -0800 (Pacific Standard Time)

> Yes, I left that in there somewhat accidentally.  I had every intention in 
> putting a get routine in, but I couldn't come up with a generic way to 
> work with most hardware (how to get all filters back and dump them).  The 
> 82599 needs to query the hardware for each filter currently programmed, 
> and I'm not sure what the niu hardware layout is for the filters.

NIU simply has a TCAM array that you can read the values back from.

> I can remove the get stubs for now, since I have no good solution to dump 
> the filters that is generic.

For hardware where it's difficult to read the values back, you
can maintain a copy of the current filters in software.

Just an idea.  If you need you'll need something like this for
multiple drivers already, probably we can put the helper code
into ethtool.c and just maintain a software copy in the kernel
for all devices.  Even one's for which fetching is straightforward.

And anyways, I can't see this being a usable interface if the current
set of filters can't be queried by the user.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html