netdev - Re: [net-next-2.6 PATCH 4/5] ixgbe: Add Flow Director configuration support as a mod parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.WNT.4.64.1001080036070.15300@ppwaskie-MOBL2.amr.corp.intel.com>
Date:	Fri, 8 Jan 2010 00:36:30 -0800 (Pacific Standard Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	David Miller <davem@...emloft.net>
cc:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"deri@...p.org" <deri@...p.org>,
	"Gasparakis, Joseph" <joseph.gasparakis@...el.com>
Subject: Re: [net-next-2.6 PATCH 4/5] ixgbe: Add Flow Director configuration
 support as a mod parameter

On Fri, 8 Jan 2010, David Miller wrote:

> From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
> Date: Fri, 8 Jan 2010 00:28:17 -0800 (Pacific Standard Time)
> 
> > On Fri, 8 Jan 2010, David Miller wrote:
> > 
> >> Use a generic ethtool boolean flag or similar, not "yet another
> >> different-in-every-driver" module parameter please.
> > 
> > Something added to the setflags routine perhaps?
> 
> Yeah, something via 'struct ethtool_flags' is probably appropriate.

Cool.  I'll respin and get rid of the module parameter.

Thanks for the review,

-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html