netdev - Re: [PATCH 1/2] improve netem reorder flexibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <201001171311.19278.christian.samsel@rwth-aachen.de>
Date:	Sun, 17 Jan 2010 13:11:18 +0100
From:	Christian Samsel <christian.samsel@...h-aachen.de>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, christian.samsel@...h-aachen.de,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] improve netem reorder flexibility

Am Samstag, 16. Januar 2010 10:46:54 schrieb David Miller:
> 
> This is a really dangerous way to handle this.
> 
> This means if you grow qopt, older kernels think that the
> extended area is attributes.
> 
> This also means that if you have new tools and send a qopt +
> attributes, older kernels won't find the start of the attributes
> correctly.  It will miss the attributes entirely.
True, i know now. 

> This is a complete mess, and we need to sort it out before we think
> about changing the size of qopt at this point.
> 
Just to state this clearly, by cleaning up the mess you mean switching netem 
completely over to netlink attributes? 

I think 4B3A5F84.4050603@...oo.it would also take advantage of that. The 
approach they choosed looks a bit wierd to me,  cause someday we could end up 
having 
tc qdisc add dev eth0 root netem
tc qdisc add dev eth0 root netem2
tc qdisc add dev eth0 root netem3
..

Christian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html