[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100117.185636.163664050.davem@davemloft.net>
Date: Sun, 17 Jan 2010 18:56:36 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: christian.samsel@...h-aachen.de
Cc: shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] improve netem reorder flexibility
From: Christian Samsel <christian.samsel@...h-aachen.de>
Date: Sun, 17 Jan 2010 13:11:18 +0100
> Am Samstag, 16. Januar 2010 10:46:54 schrieb David Miller:
>> This is a complete mess, and we need to sort it out before we think
>> about changing the size of qopt at this point.
>>
> Just to state this clearly, by cleaning up the mess you mean switching netem
> completely over to netlink attributes?
I think the only way we can proceed is to keep the current qopt
structure static, and only add things using new attributes.
I would also suggest that we make sch_netem.c strictly require a
specific size for the structure. And before anyone says that will
break something, it's much better than what we have now which is
random, silent, dropping of attributes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists