[an error occurred while processing this directive]
[an error occurred while processing this directive]
|
|
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100117.190540.22362723.davem@davemloft.net>
Date: Sun, 17 Jan 2010 19:05:40 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: ja@....bg
Cc: opurdila@...acom.com, netdev@...r.kernel.org, chavey@...gle.com
Subject: Re: [PATCH v2] ipv4: support for request type gratuitous ARP
From: Julian Anastasov <ja@....bg>
Date: Sun, 17 Jan 2010 22:43:54 +0200 (EET)
> Looks correct to me. You will save some CPU cycles
> if the 'arp->ar_op == htons(ARPOP_REQUEST)' check is not added.
> May be you also need to change arp_accept in
> Documentation/networking/ip-sysctl.txt to show that we do not
> differentiate Gratuitous ARP requests from replies.
Octavian, please make the documentation fix for 'arp_accept'
and resubmit your patch.
It otherwise looks fine to me now.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists