netdev - Re: [PATCH] phylib: Move workqueue initialization to a proper place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100119.020029.55299562.davem@davemloft.net>
Date:	Tue, 19 Jan 2010 02:00:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	avorontsov@...mvista.com
Cc:	nsekhar@...com, netdev@...r.kernel.org
Subject: Re: [PATCH] phylib: Move workqueue initialization to a proper place

From: Anton Vorontsov <avorontsov@...mvista.com>
Date: Mon, 18 Jan 2010 18:37:16 +0300

> commit 541cd3ee00a4fe975b22fac6a3bc846bacef37f7 ("phylib: Fix deadlock
> on resume") caused TI DaVinci EMAC ethernet driver to oops upon resume:
 ...
> The oops pops up because TI DaVinci EMAC driver detaches PHY on
> suspend and attaches it back on resume. Attaching makes phylib call
> phy_start_machine() that initializes a workqueue. On the other hand,
> PHY's resume routine will call phy_start_machine() again, and that
> will cause the oops since we just destroyed the already scheduled
> workqueue.
> 
> This patch fixes the issue by moving workqueue initialization to
> phy_device_create().
> 
> p.s. We don't see this oops with ucc_geth and gianfar drivers because
> they perform a fine-grained suspend, i.e. they just stop the PHYs
> without detaching.
> 
> Reported-by: Sekhar Nori <nsekhar@...com>
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> Tested-by: Sekhar Nori <nsekhar@...com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html