netdev - Re: [PATCH] ucc_geth: Fix full TX queue processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100119.020038.152864417.davem@davemloft.net>
Date:	Tue, 19 Jan 2010 02:00:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	avorontsov@...mvista.com
Cc:	B06378@...escale.com, leoli@...escale.com,
	lsorense@...lub.uwaterloo.ca, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] ucc_geth: Fix full TX queue processing

From: Anton Vorontsov <avorontsov@...mvista.com>
Date: Mon, 18 Jan 2010 18:47:50 +0300

> From: Jiajun Wu <b06378@...escale.com>
> 
> commit 7583605b6d29f1f7f6fc505b883328089f3485ad ("ucc_geth: Fix empty
> TX queue processing") fixed empty TX queue mishandling, but didn't
> account another corner case: when TX queue becomes full.
> 
> Without this patch the driver will stop transmiting when TX queue
> becomes full since 'bd == ugeth->txBd[txQ]' actually checks for
> two things: queue empty or full.
> 
> Let's better check for NULL skb, which unambiguously signals an empty
> queue.
> 
> Signed-off-by: Jiajun Wu <b06378@...escale.com>
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html