netdev - Re: [RFC PATCH] e100: Fix workqueue race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100121092035.6c4d398d@nehalam>
Date:	Thu, 21 Jan 2010 09:20:35 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	jesse.brandeburg@...el.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] e100: Fix workqueue race

On Thu, 21 Jan 2010 16:48:01 +0000
Alan Cox <alan@...ux.intel.com> wrote:

> (Incidentally this doesn't seem to be the only net driver that looks
> suspect here)
> 
> e100: Fix the TX workqueue race
> 
> From: Alan Cox <alan@...ux.intel.com>
> 
> Nothing stops the workqueue being left to run in parallel with close or a
> few other operations. This causes double unmaps and the like.
> 
> See kerneloops.org #1041230 for an example
> 
> Signed-off-by: Alan Cox <alan@...ux.intel.com>

Most drivers solve this by getting rtnl_lock in the timeout work
function.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html