netdev - RE: [PATCH net-next-2.6 03/13] net-caif: add CAIF generic protocol stack header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61D8D34BB13CFE408D154529C120E079032320DE@eseldmw101.eemea.ericsson.se>
Date:	Fri, 22 Jan 2010 12:02:19 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<marcel@...tmann.org>, <stefano.babic@...ic.homelinux.org>,
	<randy.dunlap@...cle.com>
Subject: RE: [PATCH net-next-2.6 03/13] net-caif: add CAIF generic protocol stack header files

Hi Patrick.

Patrick McHardy wrote:
> sjur.brandeland@...ricsson.com wrote:
>> +++ b/include/net/caif/generic/cfglue.h
... 
> This file looks like it should go away completely.
...
> Why are you not using the list.h functions?

I kind of expected this feedback.
The reason is that CAIF originally was written as a OS independent stack, 
with a thin glue layer for OS specific things.
I am aware that this is not the preferred way of doing it in the Linux kernel.
As mentioned to Marcel Holtmann, my problem is that I have more than 50 unit
tests in User Space that I might have to ditch if I remove cfglue.h and list.h.

But I'll probably do as you suggest in the next patch set...

BR/Sjur

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html