netdev - RE: [PATCH net-next-2.6 02/13] net-caif: add CAIF header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jan 2010 12:05:18 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<marcel@...tmann.org>, <stefano.babic@...ic.homelinux.org>
Subject: RE: [PATCH net-next-2.6 02/13] net-caif: add CAIF header files

Hi Randy.
Randy Dunlap wrote:
> Just a couple of nits here (below):
>> +++ b/include/linux/caif/caif_config.h
> ...
>> +struct caif_channel_config {
>> +	char name[16];
>> +	enum caif_channel_type type;
>> +	unsigned priority;
>> +	enum caif_phy_preference phy_pref;
>> +	char phy_name[16];
>> +
>> +	/** Union of channel type-specific configuration parameters.
> 
> Don't use /** here.
OK,
> 
>> +
>> +/**
>> + * struct ifcaif_param - Parameters for creating CAIF Network
>> Interface. + * + * When using SIOCCAIFNETNEW to create a CAIF IP
>> interface, this +structure + * is used for configuration data.
>> + * The attribute ifr_ifru.ifru_data in struct struct ifreq must be
>> +set + * point at an instance of struct ifcaif_param.
>> + *
>> + * @ipv4_connid:  Connection ID for IPv4 PDP Context.
>> + * @ipv6_connid:  Connection ID for IPv6 PDP Context.
>> + * @loop:	  If different from zero, device is doing loopback + */
>> +struct ifcaif_param {
>> +	__u32			ipv4_connid;
>> +	__u32			ipv6_connid;
>> +	__u8			loop;
>> +};
>> +
>> +/**
>> + * enum ifla_caif
> 
> Above line needs " - <short description>" on it.
Sure, I'll add that - thanks.
> 

BR/Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html