netdev - Re: [PATCH 2/2] e1000: Fix DMA mapping error handling on RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2391001221942i65143cdfq9b5c6ff3258d099e@mail.gmail.com>
Date:	Fri, 22 Jan 2010 19:42:49 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Anton Blanchard <anton@...ba.org>
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Yi Zou <yi.zou@...el.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] e1000: Fix DMA mapping error handling on RX

On Thu, Jan 21, 2010 at 03:44, Anton Blanchard <anton@...ba.org> wrote:
>
> Check for error return from pci_map_single/pci_map_page and clean up.
>
> With this and the previous patch the driver was able to handle a significant
> percentage of errors (I set the fault injection rate to 10% and could still
> download large files at a reasonable speed).
>
> Signed-off-by: Anton Blanchard <anton@...ba.org>
> ---
>
> I wasn't able to stress the jumbo frame path, so that part could do with some
> more eyes.
>
> Index: linux.trees.git/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- linux.trees.git.orig/drivers/net/e1000/e1000_main.c 2010-01-21 11:13:10.000000000 +1100
> +++ linux.trees.git/drivers/net/e1000/e1000_main.c      2010-01-21 11:15:54.000000000 +1100
> @@ -4014,11 +4014,21 @@ check_page:
>                        }
>                }
>
> -               if (!buffer_info->dma)
> +               if (!buffer_info->dma) {
>                        buffer_info->dma = pci_map_page(pdev,
>                                                        buffer_info->page, 0,
>                                                        buffer_info->length,
>                                                        PCI_DMA_FROMDEVICE);
> +                       if (pci_dma_mapping_error(pdev, buffer_info->dma)) {
> +                               put_page(buffer_info->page);
> +                               dev_kfree_skb(skb);
> +                               buffer_info->page = NULL;
> +                               buffer_info->skb = NULL;
> +                               buffer_info->dma = 0;
> +                               adapter->alloc_rx_buff_failed++;
> +                               break; /* while !buffer_info->skb */
> +                       }
> +               }
>
>                rx_desc = E1000_RX_DESC(*rx_ring, i);
>                rx_desc->buffer_addr = cpu_to_le64(buffer_info->dma);
> @@ -4109,6 +4119,13 @@ map_skb:
>                                                  skb->data,
>                                                  buffer_info->length,
>                                                  PCI_DMA_FROMDEVICE);
> +               if (pci_dma_mapping_error(pdev, buffer_info->dma)) {
> +                       dev_kfree_skb(skb);
> +                       buffer_info->skb = NULL;
> +                       buffer_info->dma = 0;
> +                       adapter->alloc_rx_buff_failed++;
> +                       break; /* while !buffer_info->skb */
> +               }
>
>                /*
>                 * XXX if it was allocated cleanly it will never map to a

I have added this patch to my queue of patches for review and testing.  Thanks.

-- 
Cheers,
Jeff