lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100124004753.GB2996@kryten> Date: Sun, 24 Jan 2010 11:47:53 +1100 From: Anton Blanchard <anton@...ba.org> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>, Bruce Allan <bruce.w.allan@...el.com>, PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>, John Ronciak <john.ronciak@...el.com>, Don Skidmore <donald.c.skidmore@...el.com>, Yi Zou <yi.zou@...el.com>, Alexander Duyck <alexander.h.duyck@...el.com>, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, Roel Kluin <roel.kluin@...il.com> Subject: Re: [PATCH 1/2] e1000: Fix DMA mapping error handling on TX Hi, > This patch does not apply to the current e1000 driver in net-2.6, much > of this patch has already been corrected (applied) by Roel Kluin > recent patch. Sorry I was basing off net-next. I just compared it to my fix and looks like the patch in net-2.6 has an off by one error doesn't it? Anton -- Subject: [PATCH] e1000: Fix DMA mapping error handling on TX e1000_tx_map has an off by one error in the dma mapping error cleanup path. We decrement count and never clean the first successfully mapped descriptor. Signed-off-by: Anton Blanchard <anton@...ba.org> --- diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index d29bb53..427cedd 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -2790,8 +2790,6 @@ static int e1000_tx_map(struct e1000_adapter *adapter, dma_error: dev_err(&pdev->dev, "TX DMA map failed\n"); buffer_info->dma = 0; - if (count) - count--; while (count--) { if (i==0) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists