netdev - Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B5DDF70.8010709@LiPPERTEmbedded.de>
Date:	Mon, 25 Jan 2010 19:14:08 +0100
From:	Jens Rottmann <JRottmann@...PERTEmbedded.de>
To:	Tristram Ha <Tristram.Ha@...rel.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver

In ksz884x.c: read_other_addr(struct ksz_hw *hw)

"u16 data[3]" instead of "u16 data[4]" is sufficient.

And when checking if the 2nd MAC is actually stored in EEPROM or if it's only
all empty (only FF) you overlooked that you're doing it wordwise, so you'll
have to check "data[0] != 0xffff" instead of "data[0] != 0xff".

Best regards,
Jens Rottmann

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html