netdev - Re: [PATCH 01/25 v2] mlx4_core: identify function as pf or vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adar5peouu3.fsf@roland-alpha.cisco.com>
Date:	Mon, 25 Jan 2010 11:20:04 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	liranl@...lanox.co.il, tziporet@...lanox.co.il
Subject: Re: [PATCH 01/25 v2] mlx4_core: identify function as pf or vf


 >  enum {
 >  	MLX4_FLAG_MSI_X		= 1 << 0,
 >  	MLX4_FLAG_OLD_PORT_CMDS	= 1 << 1,
 > +	MLX4_FLAG_MASTER	= 1 << 2,
 > +	MLX4_FLAG_SLAVE		= 1 << 3,
 > +	MLX4_FLAG_SRIOV		= 1 << 4,
 >  };

I'm a bit confused by these flags.  As far as I can tell, the SRIOV flag
will be set if and only if MASTER is set too... so in other words we
might as well just have the MASTER and SLAVE flags and not have the
SRIOV flag at all.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html