netdev - Re: [patch 1/1] starfire: clean up properly if firmware loading fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100126.204916.34896841.davem@davemloft.net>
Date:	Tue, 26 Jan 2010 20:49:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	michael@...fatt.org.nz, stable@...nel.org
Subject: Re: [patch 1/1] starfire: clean up properly if firmware loading
 fails

From: akpm@...ux-foundation.org
Date: Tue, 26 Jan 2010 20:27:09 -0800

> From: Ben Hutchings <bhutchings@...arflare.com>
> 
> netdev_open() will return without cleaning up net device or hardware state
> if firmware loading fails.  This results in a BUG() on a second attempt to
> bring the interface up, reported in
> <http://bugzilla.kernel.org/show_bug.cgi?id=15117>, and probably has even
> worse effects if the driver is removed afterwards.
> 
> Call netdev_close() to clean up on failure.
> 
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=15091
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> Reported-by: Michael Moffatt <michael@...fatt.org.nz>
> Tested-by: Michael Moffatt <michael@...fatt.org.nz>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: <stable@...nel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html