netdev - Re: [patch 1/1] starfire: clean up properly if firmware loading fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1264568297.373.482.camel@localhost>
Date:	Wed, 27 Jan 2010 04:58:17 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	davem@...emloft.net
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	michael@...fatt.org.nz, stable@...nel.org
Subject: Re: [patch 1/1] starfire: clean up properly if firmware loading
 fails

On Tue, 2010-01-26 at 20:27 -0800, akpm@...ux-foundation.org wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> 
> netdev_open() will return without cleaning up net device or hardware state
> if firmware loading fails.  This results in a BUG() on a second attempt to
> bring the interface up, reported in
> <http://bugzilla.kernel.org/show_bug.cgi?id=15117>, and probably has even
> worse effects if the driver is removed afterwards.

David, please correct the URL above before applying the patch so I don't
continue to look like an idiot. :-)  It should be
<http://bugzilla.kernel.org/show_bug.cgi?id=15091> as added by Andrew
below.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html