netdev - Re: [PATCH net-next-2.6] packet: Add GSO/checksum offload support to af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100129232212.GA7333@gondor.apana.org.au>
Date:	Sat, 30 Jan 2010 10:22:12 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Sridhar Samudrala <sri@...ibm.com>
Cc:	David Miller <davem@...emloft.net>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] packet: Add GSO/checksum offload support
	to af_packet sockets

On Fri, Jan 29, 2010 at 02:30:49PM -0800, Sridhar Samudrala wrote:
>
> In this use-case, the component that is calling sendmsg() can be either  
> the vhost-net in host kernel
> or qemu. They get the buffer including the L2 header from the guest.  
> They too need to parse the L2
> header to find the protocol.

So have them parse the L2 header to get the protocol.  They know
that the packet should contain an Ethernet header, while this
knowledge would be inappropriate for af_packet in general.

This is also why we call eth_type_trans in network drivers as
opposed to the core.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html