netdev - Re: [PATCH v2] net/macvtap: fix reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ae48b021002121258l6f0849c6w51886bd2b2893c1c@mail.gmail.com>
Date:	Fri, 12 Feb 2010 12:58:08 -0800
From:	Ed Swierk <eswierk@...stanetworks.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Patrick McHardy <kaber@...sh.net>,
	Sridhar Samudrala <sri@...ibm.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net/macvtap: fix reference counting

On Thu, Feb 11, 2010 at 7:55 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The RCU usage in the original code was broken because
> there are cases where we possibly sleep with rcu_read_lock
> held. As a fix, change the macvtap_file_get_queue to
> get a reference on the socket and the netdev instead of
> taking the full rcu_read_lock.
>
> Also, change macvtap_file_get_queue failure case to
> not require a subsequent macvtap_file_put_queue, as
> pointed out by Ed Swierk.

Works for me. Thanks.

Acked-by: Ed Swierk <eswierk@...stanetworks.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html