netdev - Re: [PATCH v2] net/macvtap: fix reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100215.215341.66627877.davem@davemloft.net>
Date:	Mon, 15 Feb 2010 21:53:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sri@...ibm.com
Cc:	arnd@...db.de, kaber@...sh.net, eswierk@...stanetworks.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] net/macvtap: fix reference counting

From: Sridhar Samudrala <sri@...ibm.com>
Date: Thu, 11 Feb 2010 13:09:37 -0800

> On Thu, 2010-02-11 at 16:55 +0100, Arnd Bergmann wrote:
>> The RCU usage in the original code was broken because
>> there are cases where we possibly sleep with rcu_read_lock
>> held. As a fix, change the macvtap_file_get_queue to
>> get a reference on the socket and the netdev instead of
>> taking the full rcu_read_lock.
>> 
>> Also, change macvtap_file_get_queue failure case to
>> not require a subsequent macvtap_file_put_queue, as
>> pointed out by Ed Swierk.
> 
> Looks good.
> 
> Acked-by: Sridhar Samudrala <sri@...ibm.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html