netdev - Re: [PATCH net-2.6] net: bug fix for vlan + gro issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100217064030.GA15791@gondor.apana.org.au>
Date:	Wed, 17 Feb 2010 14:40:30 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ajit Khaparde <ajitk@...verengines.com>
Cc:	davem@...emloft.net, kaber@...sh.net,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-2.6] net: bug fix for vlan + gro issue

On Wed, Feb 17, 2010 at 11:55:43AM +0530, Ajit Khaparde wrote:
>
> Here is the patch:-
> 
> Traffic (tcp) doesnot start on a vlan interface when gro is enabled.
> Even the tcp handshake was not taking place.
> This is because, the eth_type_trans call before the netif_receive_skb
> in napi_gro_finish() resets the skb->dev to napi->dev from the previously
> set vlan netdev interface. This causes the ip_route_input to drop the
> incoming packet considering it as a packet coming from a martian source.
> 
> I could repro this on 2.6.32.7 (stable) and 2.6.33-rc7.
> With this fix, the traffic starts and the test runs fine on both vlan
> and non-vlan interfaces.
> 
> CC: Herbert Xu <herbert@...dor.apana.org.au>
> CC: Patrick McHardy <kaber@...sh.net>
> Signed-off-by: Ajit Khaparde <ajitk@...verengines.com>

Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks a lot!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html