netdev - Re: [PATCH net-2.6] net: bug fix for vlan + gro issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100217.160251.170027820.davem@davemloft.net>
Date:	Wed, 17 Feb 2010 16:02:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ajitk@...verengines.com, ajitkhaparde@...il.com
Cc:	herbert@...dor.apana.org.au, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] net: bug fix for vlan + gro issue

From: Ajit Khaparde <ajitkhaparde@...il.com>
Date: Wed, 17 Feb 2010 11:55:43 +0530

> Thanks Herbert. I think you meant something like this:
> +		skb->protocol = eth_type_trans(skb, skb->dev);
> 
> Here is the patch:-
> 
> Traffic (tcp) doesnot start on a vlan interface when gro is enabled.
> Even the tcp handshake was not taking place.
> This is because, the eth_type_trans call before the netif_receive_skb
> in napi_gro_finish() resets the skb->dev to napi->dev from the previously
> set vlan netdev interface. This causes the ip_route_input to drop the
> incoming packet considering it as a packet coming from a martian source.
> 
> I could repro this on 2.6.32.7 (stable) and 2.6.33-rc7.
> With this fix, the traffic starts and the test runs fine on both vlan
> and non-vlan interfaces.
> 
> CC: Herbert Xu <herbert@...dor.apana.org.au>
> CC: Patrick McHardy <kaber@...sh.net>
> Signed-off-by: Ajit Khaparde <ajitk@...verengines.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html