netdev - Re: [PATCH net-next-2.6] be2net: free tx buffers when completions never arrive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100218.021616.127015823.davem@davemloft.net>
Date:	Thu, 18 Feb 2010 02:16:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sathyap@...verengines.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] be2net: free tx buffers when completions
 never arrive

From: Sathya Perla <sathyap@...verengines.com>
Date: Thu, 18 Feb 2010 15:06:03 +0530

> In cases like when a pci device is disconnected after a pci error,
> pending tx completions will never arrive. Unmap and free such
> buffers in the tx cleanup path.
> 
> Signed-off-by: Sathya Perla <sathyap@...verengines.com>
> ---
>  drivers/net/benet/be_main.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
> index 68e7848..810d2a4 100644
> --- a/drivers/net/benet/be_main.c
> +++ b/drivers/net/benet/be_main.c
> @@ -1128,6 +1128,9 @@ static void be_tx_compl_clean(struct be_adapter *adapter)
>  	struct be_queue_info *txq = &adapter->tx_obj.q;
>  	struct be_eth_tx_compl *txcp;
>  	u16 end_idx, cmpl = 0, timeo = 0;
> +	struct sk_buff **sent_skbs = adapter->tx_obj.sent_skb_list;
> +	struct sk_buff *sent_skb;
> +        bool dummy_wrb;

Some of your lines start with tabs, some with spaces.   You
have to use tabs consistently.

> +	
> +	/* free posted tx for which compls will never arrive */
> +        while (atomic_read(&txq->used)) {
> +                sent_skb = sent_skbs[txq->tail];
> +                end_idx = txq->tail;
> +                index_adv(&end_idx,
> +                        wrb_cnt_for_skb(sent_skb, &dummy_wrb) - 1, txq->len);
> +                be_tx_compl_process(adapter, end_idx);
> +        }
>  }

More tabbing and indentation problems here too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html