[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100218193733.GA23337@jenkins.home.ifup.org>
Date: Thu, 18 Feb 2010 11:37:33 -0800
From: Brandon Philips <brandon@...p.org>
To: Francois Romieu <romieu@...zoreil.com>
Cc: Neil Horman <nhorman@...driver.com>,
David Miller <davem@...emloft.net>, ben@...adent.org.uk,
eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH RFC] r8169: straighten out overlength frame detection
(v3)
On 16:50 Sat 30 Jan 2010, Neil Horman wrote:
> On Tue, Jan 12, 2010 at 01:16:46AM +0100, Francois Romieu wrote:
> > On Sun, Jan 10, 2010 at 10:45:04PM -0800, David Miller wrote:
> > [...]
> > > In my opinion if you reset, you give them more power.
> > >
> > > Instead of just dropping the next few frames, you allow them
> > > to cause a drop of how ever many RX frames can arrive during
> > > the reset period _PLUS_ the amount of other RX frames which
> > > were in the receive ring at the point of detection.
> >
> > Sure.
> >
> > The fragmented frame test has been moved a few lines up, before checking
> > for the status bits. Exceedingly small frames are detected and dropped
> > as well.
> >
> > I have spent the evening disrupting the communication. As a challenger
> > one does not even need complete control : send a few random packets and
> > the card goes to neverland. :o/
> >
> > I'll do some tests limiting the crap at the first packet.
> >
> Any further results you can share with us Francois?
Can I offer any help? I found that I have access to a Rev 0x10 card.
Cheers,
Brandon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists