netdev - Re: [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1266541970.1891.109.camel@vi2.jf.intel.com>
Date:	Thu, 18 Feb 2010 17:12:50 -0800
From:	Vasu Dev <vasu.dev@...ux.intel.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, vasu.dev@...el.com
Subject: Re: [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select_queue

On Thu, 2010-02-18 at 08:37 +0100, Eric Dumazet wrote:
> > This means vlan_netdev_ops & vlan_netdev_accel_ops not to be const
> > anymore so that vlan_dev_select_queue() could be initialized to vlan
> ops
> > based on real dev ndo_select_queue() present or not, should be okay
> to
> > be not const anymore. I'll update patch as suggested.
> 
> No they should stay const
> 
> I said you should mirror (copy if you prefer) the structure, one with
> a
> NULL ndo_select_queue pointer, one with a ndo_select_queue =
> vlan_dev_select_queue.
> 
> Both structures are const.
> 
> You must not dynamiucally change the structure, because the same
> machine
> might have a vlan over a device with no ndo_select_queue() method, and
> another vlan over a device with a ndo_select_queue()
> 

I see, I'll mirror existing vlan op structs to have them w/ and w/o
vlan_dev_select_queue while having all vlan ops statically defined
const.

	Thanks Eric.
	Vasu

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html