netdev - Re: [net-next-2.6 PATCH 1/7] xfrm: introduce basic mark infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100221.222612.112587589.davem@davemloft.net>
Date:	Sun, 21 Feb 2010 22:26:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hadi@...erus.ca
Cc:	timo.teras@....fi, kaber@...sh.net, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH 1/7] xfrm: introduce basic mark
 infrastructure

From: jamal <hadi@...erus.ca>
Date: Sat, 20 Feb 2010 15:55:34 -0500

>  	XFRMA_ALG_AUTH_TRUNC,	/* struct xfrm_algo_auth */
> +	XFRMA_MARK,		/* u32 */
>  	__XFRMA_MAX
>  

XFRM_MARK is "struct xfrm_*mask" not "u32".

> +struct xfrm_kmark {
> +	u32           v; /* value */
> +	u32           m; /* mask */
> +};
> +

You absolutely don't need this song and dance.

If the userspace attribute type equals the kernel one, you can just
define one "struct xfrm_mark" in linux/xfrm.h and use it universally.

This is how we handle this with other XFRM userspace visible
datastructures.

We only make seperate internal ones when they have to be different for
some reason, which is not true here.

Please respin your entire patch set once you've fixed this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html