netdev - Re: [PATCH V2 net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1266808995.2930.24.camel@obelisk.thedillows.org>
Date:	Sun, 21 Feb 2010 22:23:15 -0500
From:	David Dillow <dave@...dillows.org>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH V2 net-next 14/15] drivers/net/typhoon.c: Use
 (pr|netdev)_<level> macro helpers

On Sun, 2010-02-21 at 19:08 -0800, Joe Perches wrote: 
> David Dillow took my suggestions and improved on them.
> Here is this latest version.
> 
> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove #define PFX
> Remove #define ERR_PFX
> Remove now unused member name from struct typhoon
> Use pr_<level>
> Use netdev_<level>
> Coalesce long formats
> Remove version information
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> Signed-off-by: David Dillow <dave@...dillows.org>

Perhaps commit text as follows? I can sign-off on it, but I don't think
my effort rises to that level. I certainly ack the patch, though.

typhoon: clean up message output
    
Use the new netdev_* helpers to clean up and make the logging output
more consistent with other network drivers. This also removes the
constantly-stale version info in favor of using the kernel version from
which the module was built.

Signed-off-by: Joe Perches <joe@...ches.com>
Acked-by: David Dillow <dave@...dillows.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html