| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100222.154306.114398657.davem@davemloft.net> Date: Mon, 22 Feb 2010 15:43:06 -0800 (PST) From: David Miller <davem@...emloft.net> To: dave@...dillows.org Cc: joe@...ches.com, netdev@...r.kernel.org Subject: Re: [PATCH V2 net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)_<level> macro helpers From: David Dillow <dave@...dillows.org> Date: Sun, 21 Feb 2010 22:23:15 -0500 > On Sun, 2010-02-21 at 19:08 -0800, Joe Perches wrote: >> David Dillow took my suggestions and improved on them. >> Here is this latest version. >> >> Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> Remove #define PFX >> Remove #define ERR_PFX >> Remove now unused member name from struct typhoon >> Use pr_<level> >> Use netdev_<level> >> Coalesce long formats >> Remove version information >> >> Signed-off-by: Joe Perches <joe@...ches.com> >> Signed-off-by: David Dillow <dave@...dillows.org> > > Perhaps commit text as follows? Man you are picky :-/ Are you a control freak? You can't even let Joe write his commit comments consistently with the ones he is using for all the other similar network driver transmations? What makes doing the same exact transformations to your favorite driver so special that it deserves a specially constructed commit message? Tell me. Stuff like this drives me crazy. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists