netdev - Re: [PATCH] tc35815: Remove a wrong netif_wake_queue() call which triggers BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100223.012558.174368647.davem@davemloft.net>
Date:	Tue, 23 Feb 2010 01:25:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	anemo@....ocn.ne.jp
Cc:	netdev@...r.kernel.org, ralf.roesch@...gmbh.de
Subject: Re: [PATCH] tc35815: Remove a wrong netif_wake_queue() call which
 triggers BUG_ON

From: Atsushi Nemoto <anemo@....ocn.ne.jp>
Date: Sat, 20 Feb 2010 00:13:58 +0900

> The netif_wake_queue() is called correctly (i.e. only on !txfull
> condition) from txdone routine.  So Unconditional call to the
> netif_wake_queue() here is wrong.  This might cause calling of
> start_xmit routine on txfull state and trigger BUG_ON.
> 
> This bug does not happen when NAPI disabled.  After txdone there
> must be at least one free tx slot.  But with NAPI, this is not
> true anymore and the BUG_ON can hits on heavy load.
> 
> In this driver NAPI was enabled on 2.6.33-rc1 so this is
> regression from 2.6.32 kernel.
> 
> Reported-by: Ralf Roesch <ralf.roesch@...gmbh.de>
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

Patch applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html