netdev - Re: [PATCH] tc35815: Remove a wrong netif_wake_queue() call which triggers BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100223.012614.109539080.davem@davemloft.net>
Date:	Tue, 23 Feb 2010 01:26:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	anemo@....ocn.ne.jp
Cc:	netdev@...r.kernel.org, ralf.roesch@...gmbh.de
Subject: Re: [PATCH] tc35815: Remove a wrong netif_wake_queue() call which
 triggers BUG_ON

From: Atsushi Nemoto <anemo@....ocn.ne.jp>
Date: Sat, 20 Feb 2010 00:31:22 +0900 (JST)

> On Sat, 20 Feb 2010 00:13:58 +0900, Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:
>> @@ -1437,7 +1437,6 @@ static int tc35815_do_interrupt(struct net_device *dev, u32 status, int limit)
>>  		/* Transmit complete. */
>>  		lp->lstats.tx_ints++;
>>  		tc35815_txdone(dev);
>> -		netif_wake_queue(dev);
>>  		if (ret < 0)
>>  			ret = 0;
>>  	}
> 
> BTY, it looks isa-skelton.c have same problem.
 ...
> I suppose here is the far origin of the bug :)

Please send a patch for this.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html