netdev - Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2391002240153r2c1c73e1x718c69effa90120f@mail.gmail.com>
Date:	Wed, 24 Feb 2010 01:53:12 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"Oleg A. Arkhangelsky" <sysoleg@...dex.ru>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN 
	devices

On Tue, Feb 23, 2010 at 11:36, "Oleg A. Arkhangelsky" <sysoleg@...dex.ru> wrote:
> 23.02.10, 15:59, "Ben Hutchings" <bhutchings@...arflare.com>:
>
>>  The queue mapping will normally be the same, only no longer biased by 1.
>>  So I think a better solution would be to maintain that bias on TX as
>>  well, or to remove the bias and reserve -1 for unknown RX queue.
>
> Second try. Not tested but looks OK.
>
> Must be applied with "[net-next-2.6 PATCH] Multiqueue support for bonding devices"
>
> Forwarded packet goes through dev_queue_xmit() more that once when using bonding
> or 802.1q VLAN devices, so we've lost rx-tx queue mapping index for real devices.
> This is because initial queue index value (as it recorded by skb_record_tx_queue())
> is overwritten by skb_set_queue_mapping().
>
> Signed-off-by: Oleg A. Arkhangelsky <sysoleg@...dex.ru>
>
> ---
>  drivers/net/bnx2.c             |    2 +-
>  drivers/net/bnx2x_main.c       |    2 +-
>  drivers/net/gianfar.c          |    6 +++---
>  drivers/net/igb/igb_main.c     |    2 +-
>  drivers/net/ixgbe/ixgbe_main.c |    6 +++---
>  drivers/net/mlx4/en_tx.c       |    2 +-
>  drivers/net/niu.c              |    2 +-
>  drivers/net/qlge/qlge_main.c   |    2 +-
>  drivers/net/s2io.c             |    2 +-
>  include/linux/skbuff.h         |   14 ++------------
>  net/core/dev.c                 |    2 +-
>  11 files changed, 16 insertions(+), 26 deletions(-)
>

Intel driver changes look fine...
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html