netdev - Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100226.055025.30718012.davem@davemloft.net>
Date:	Fri, 26 Feb 2010 05:50:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sysoleg@...dex.ru
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and
 VLAN devices

From: "\"Oleg A. Arkhangelsky\"" <sysoleg@...dex.ru>
Date: Tue, 23 Feb 2010 22:36:00 +0300

> 23.02.10, 15:59, "Ben Hutchings" <bhutchings@...arflare.com>:
> 
>>  The queue mapping will normally be the same, only no longer biased by 1.
>>  So I think a better solution would be to maintain that bias on TX as
>>  well, or to remove the bias and reserve -1 for unknown RX queue.
> 
> Second try. Not tested but looks OK.
> 
> Must be applied with "[net-next-2.6 PATCH] Multiqueue support for bonding devices"
> 
> Forwarded packet goes through dev_queue_xmit() more that once when using bonding
> or 802.1q VLAN devices, so we've lost rx-tx queue mapping index for real devices.
> This is because initial queue index value (as it recorded by skb_record_tx_queue())
> is overwritten by skb_set_queue_mapping().
> 
> Signed-off-by: Oleg A. Arkhangelsky <sysoleg@...dex.ru> 

Your patches are fine, but they are whitespace corrupted by your
email client (tabs turned into spaces, etc.) so they won't apply
properly.

Please fix this up and resend your patches.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html