lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 27 Feb 2010 11:05:14 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<marcel@...tmann.org>, <netdev@...r.kernel.org>,
	"Daniel Martensson" <daniel.martensson@...ricsson.com>,
	<kaber@...sh.net>, <stefano.babic@...ic.homelinux.org>,
	<randy.dunlap@...cle.com>
Subject: RE: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack

David Miller wrote:
>> Hi Marcel.
>>>> CHANGE LOG:
>>>> Based on review comments from David Miller and Marcel Holtmann on the
>>>> previous patch set submitted the 16 February the following changes
>>>> have been done: 
>>>> - Removed ifdef __cplusplus from caif_socket.h
>>>> - Use socket level SOL_IP for socket options SO_PRIORITY and
>>>> SO_BINDTODEVICE
>>> 
>>> are you sure it is not better to use SOL_SOCKET here. At least
>>> according to man 7 socket this would make a lot more sense. My point
>>> in actually using SO_PRIORITY and SO_BINDTODEVICE is to use standard
>>> socket options that are already used by everybody else. So they know
>>> what to expect.    
>>> 
>> Yes, this makes sense. I'll update this.
>
>Please fix this up and resubmit your patch series so I can add
>it to the net-next-2.6 tree.

I have sent a V4 patch-set, fixing the review comments on the 
V3 patch-set. But there are still review comments coming in.

Unfortunately, I am traveling until Thursday this week, without Internet access,
so if you would like me to resubmit again I will not be able to do that before
Thursday or Friday this week.

BR/Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists