lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 26 Feb 2010 01:22:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sjur.brandeland@...ricsson.com
Cc:	marcel@...tmann.org, netdev@...r.kernel.org,
	daniel.martensson@...ricsson.com, kaber@...sh.net,
	stefano.babic@...ic.homelinux.org, randy.dunlap@...cle.com
Subject: Re: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF
 protocol stack

From: Sjur Brændeland <sjur.brandeland@...ricsson.com>
Date: Tue, 23 Feb 2010 08:39:52 +0100

> Hi Marcel.
>>> CHANGE LOG:
>>> Based on review comments from David Miller and Marcel Holtmann on the
>>> previous patch set submitted the 16 February the following changes
>>> have been done: 
>>> - Removed ifdef __cplusplus from caif_socket.h
>>> - Use socket level SOL_IP for socket options SO_PRIORITY and
>>> SO_BINDTODEVICE
>> 
>> are you sure it is not better to use SOL_SOCKET here. At least
>> according to man 7 socket this would make a lot more sense. My point
>> in actually using SO_PRIORITY and SO_BINDTODEVICE is to use standard
>> socket options that are already used by everybody else. So they know
>> what to expect.    
>> 
> Yes, this makes sense. I'll update this.

Please fix this up and resubmit your patch series so I can add
it to the net-next-2.6 tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists