netdev - RE: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Feb 2010 08:39:52 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"Marcel Holtmann" <marcel@...tmann.org>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	"Daniel Martensson" <daniel.martensson@...ricsson.com>,
	<kaber@...sh.net>, <stefano.babic@...ic.homelinux.org>,
	<randy.dunlap@...cle.com>
Subject: RE: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack

Hi Marcel.
>> CHANGE LOG:
>> Based on review comments from David Miller and Marcel Holtmann on the
>> previous patch set submitted the 16 February the following changes
>> have been done: 
>> - Removed ifdef __cplusplus from caif_socket.h
>> - Use socket level SOL_IP for socket options SO_PRIORITY and
>> SO_BINDTODEVICE
> 
> are you sure it is not better to use SOL_SOCKET here. At least
> according to man 7 socket this would make a lot more sense. My point
> in actually using SO_PRIORITY and SO_BINDTODEVICE is to use standard
> socket options that are already used by everybody else. So they know
> what to expect.    
> 
Yes, this makes sense. I'll update this.

BR/Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html