[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 03 Mar 2010 18:42:56 +0200
From: "Jussi Kivilinna" <jussi.kivilinna@...et.fi>
To: "Jiri Pirko" <jpirko@...hat.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [net-next-2.6 PATCH] wireless: convert to use
netdev_for_each_mc_addr
Hello!
Quoting "Jiri Pirko" <jpirko@...hat.com>:
> + } else if (mc_count) {
> + int size = min(priv->multicast_size, mc_count);
> + int i = 0;
> +
> + mc_addrs = kmalloc(size * ETH_ALEN, GFP_ATOMIC);
...
> + if (filter != basefilter)
> + goto set_filter;
> +
> + if (mc_count) {
> + ret = rndis_set_oid(usbdev, OID_802_3_MULTICAST_LIST, mc_addrs,
> + mc_count * ETH_ALEN);
> + kfree(mc_addrs);
mc_addrs was alloced by with 'size * ETH_ALEN', which might be less
than mc_count * ETH_ALEN.
Otherwise ok, and rndis_wlan works.
-Jussi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists