[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 3 Mar 2010 16:54:34 +0100
From: Jiri Pirko <jpirko@...hat.com>
To: "Frank W. Miller" <frankwmiller@...nkwmiller.net>
Cc: tcpdump-workers@...ts.tcpdump.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [tcpdump-workers] Current wireless-testing breaks libpcap:
mr_alen should be set
Wed, Mar 03, 2010 at 04:31:07PM CET, frankwmiller@...nkwmiller.net wrote:
>
>Would this be preventing pcap_inject() from working say in kernel 2.6.31
>(stock FC12 kernel)?
Nope. The patch went in just recently.
>
>Thanks,
>FM
>
>
>> -----Original Message-----
>> From: tcpdump-workers-owner@...ts.tcpdump.org [mailto:tcpdump-workers-
>> owner@...ts.tcpdump.org] On Behalf Of Pavel Roskin
>> Sent: Tuesday, March 02, 2010 6:01 PM
>> To: linux-wireless@...r.kernel.org; netdev@...r.kernel.org; tcpdump-
>> workers@...ts.tcpdump.org
>> Cc: Jiri Pirko
>> Subject: [tcpdump-workers] Current wireless-testing breaks libpcap:
>> mr_alen should be set
>>
>> Hello!
>>
>> The current wireless-testing appears to have some non-wireless bits from
>> the upcoming Linux 2.6.34. As a result, libpcap and all capture
>> programs that use it are broken.
>>
>> This patch to libpcap helps:
>>
>> --- a/pcap-linux.c
>> +++ b/pcap-linux.c
>> @@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle, const char
>> memset(&mr, 0, sizeof(mr));
>> mr.mr_ifindex = handle->md.ifindex;
>> mr.mr_type = PACKET_MR_PROMISC;
>> + mr.mr_alen = 6;
>> if (setsockopt(sock_fd, SOL_PACKET,
>> PACKET_ADD_MEMBERSHIP, &mr, sizeof(mr)) ==
>-1)
>> {
>>
>> libpcap git doesn't have the fix yet.
>>
>> The breakage must be coming from the commit 914c8ad2 by Jiri Pirko to
>> net/packet/af_packet.c
>>
>> I think it's very unhelpful to introduce patches that break significant
>> userspace functionality without giving the affected programs an advance
>> warning.
>>
>> Also, pulling bleeding edge stuff into wireless-testing before rc1
>> appears to be either a mistake or a bad decision.
>>
>> Sorry for cross-post, but it's an urgent issue. Repliers are encouraged
>> to trim the recipient list as necessary.
>>
>> --
>> Regards,
>> Pavel Roskin
>> -
>> This is the tcpdump-workers list.
>> Visit https://cod.sandelman.ca/ to unsubscribe.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists