netdev - Re: [tcpdump-workers] Current wireless-testing breaks libpcap: mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7D621661-59E7-46C4-9E86-1D9654A626E7@alum.mit.edu>
Date:	Sat, 6 Mar 2010 13:23:12 -0800
From:	Guy Harris <guy@...m.mit.edu>
To:	tcpdump-workers@...ts.tcpdump.org
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Jiri Pirko <jpirko@...hat.com>
Subject: Re: [tcpdump-workers] Current wireless-testing breaks libpcap: mr_alen should be set


On Mar 2, 2010, at 5:00 PM, Pavel Roskin wrote:

> This patch to libpcap helps:
> 
> --- a/pcap-linux.c
> +++ b/pcap-linux.c
> @@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle, const char
> 			memset(&mr, 0, sizeof(mr));
> 			mr.mr_ifindex = handle->md.ifindex;
> 			mr.mr_type    = PACKET_MR_PROMISC;
> +			mr.mr_alen    = 6;

If there are any network types that support promiscuous mode and have link-layer addresses that aren't 6 octets long, that would still fail.

It sounds as if the fix is not to care about the address length if the address isn't used, so you don't need to get the length right for PACKET_MR_PROMISC or PACKET_MR_ALLMULTI, so libpcap, and other clients setting promiscuous or "show me all multicast packets" mode, don't need to change.  Is that the case?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html