netdev - bug report: netpoll: allow execution of multiple rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100306110659.GE4958@bicker>
Date:	Sat, 6 Mar 2010 14:06:59 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Daniel Borkmann <danborkmann@...glemail.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: bug report: netpoll: allow execution of multiple rx_hooks per
	interface

Hi Dan,

Smatch complains about 508e14b4a4f: netpoll: allow execution of multiple 
rx_hooks per interface

net/core/netpoll.c +840 netpoll_setup(124) error: potential null dereference 'npinfo'.  (kmalloc returns null)
   839          if (!ndev->npinfo) {
   840                  spin_lock_irqsave(&npinfo->rx_lock, flags);

	npinfo can be null here if the kmalloc() failed.

   841                  list_for_each_entry_safe(npe, tmp, &npinfo->rx_np, rx) {
   842                          npe->dev = NULL;
   843                  }
   844                  spin_unlock_irqrestore(&npinfo->rx_lock, flags);
   845
   846                  kfree(npinfo);
   847          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html