netdev - Re: bug report: netpoll: allow execution of multiple rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B977EDB.5010202@gmail.com>
Date:	Wed, 10 Mar 2010 12:13:31 +0100
From:	Daniel Borkmann <danborkmann@...glemail.com>
To:	Dan Carpenter <error27@...il.com>
CC:	Daniel Borkmann <danborkmann@...glemail.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: bug report: netpoll: allow execution of multiple rx_hooks per
 interface

Hi Dan,

Dan Carpenter wrote:
> Smatch complains about 508e14b4a4f: netpoll: allow execution of multiple 
> rx_hooks per interface
> 
> net/core/netpoll.c +840 netpoll_setup(124) error: potential null dereference 'npinfo'.  (kmalloc returns null)
>    839          if (!ndev->npinfo) {
>    840                  spin_lock_irqsave(&npinfo->rx_lock, flags);
> 
> 	npinfo can be null here if the kmalloc() failed.
> 
>    841                  list_for_each_entry_safe(npe, tmp, &npinfo->rx_np, rx) {
>    842                          npe->dev = NULL;
>    843                  }
>    844                  spin_unlock_irqrestore(&npinfo->rx_lock, flags);
>    845
>    846                  kfree(npinfo);
>    847          }

Sorry for the late reply, I'm currently on holiday and have hardly
access to the Internet. I'll fix the problem as soon as possible.

You'll hear from me.

Thanks,
Daniel


Download attachment "signature.asc" of type "application/pgp-signature" (262 bytes)