netdev - Re: [PATCH RFC] fix problems with NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adar5nshqyr.fsf@roland-alpha.cisco.com>
Date:	Wed, 10 Mar 2010 12:17:00 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Robert Hancock <hancockrwd@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	Linux-usb <linux-usb@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: Re: [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2

 > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
 > index df3eb8c..53be462 100644
 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
 > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
 > @@ -1058,7 +1058,7 @@ static void ipoib_setup(struct net_device *dev)
 >  	dev->type		 = ARPHRD_INFINIBAND;
 >  	dev->tx_queue_len	 = ipoib_sendq_size * 2;
 >  	dev->features		 = (NETIF_F_VLAN_CHALLENGED	|
 > -				    NETIF_F_HIGHDMA);
 > +				    NETIF_F_DMA_HIGH);
 >  	dev->priv_flags		&= ~IFF_XMIT_DST_RELEASE;
 >  
 >  	memcpy(dev->broadcast, ipv4_bcast_addr, INFINIBAND_ALEN);

Been meaning to mention this for a bit, but ipoib is capable of handling
any DMA address, so if I understand your patch correctly, this can be
NETIF_F_DMA_64BIT instead of just DMA_HIGH.
-- 
Roland Dreier  <rolandd@...co.com>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html